lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl (JIRA) <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8818) smokeTestRelease.py encoding bug
Date Sat, 01 Jun 2019 19:24:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853797#comment-16853797
] 

Jan Høydahl commented on LUCENE-8818:
-------------------------------------

Byte 0xf8 is Norwegian “ø” which would be in log file since it is in my name. It works
fine for many devs, and my guess is that Andrzej’s shell did not have UTF-8 as default encoding/locale.
Thus the script should probably not specify encoding for this open() at all but use system
default.

> smokeTestRelease.py encoding bug
> --------------------------------
>
>                 Key: LUCENE-8818
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8818
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>            Priority: Minor
>
> Smoke tester may crash while parsing log file created from gpg stdout, but only in certain
conditions. Error trace is
> {code:java}
> Test Lucene...
>  test basics...
>  check changes HTML...
>  download lucene-7.7.2-src.tgz...
>    43.5 MB in 123.23 sec (0.4 MB/sec)
>    verify sha512 digest
>    verify sig
> Traceback (most recent call last):
>  File "dev-tools/scripts/smokeTestRelease.py", line 1518, in <module>
>    main()
>  File "dev-tools/scripts/smokeTestRelease.py", line 1448, in main
>    smokeTest(c.java, c.url, c.revision, c.version, c.tmp_dir, c.is_signed, c.local_keys,
' '.join(c.test_args))
>  File "dev-tools/scripts/smokeTestRelease.py", line 1497, in smokeTest
>    checkSigs('lucene', lucenePath, version, tmpDir, isSigned, keysFile)
>  File "dev-tools/scripts/smokeTestRelease.py", line 379, in checkSigs
>    for line in f.readlines():
>  File "/Users/ab/anaconda3/lib/python3.7/codecs.py", line 322, in decode
>    (result, consumed) = self._buffer_decode(data, self.errors, final)
> UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf8 in position 180: invalid start
byte{code}
> The failing line is https://github.com/apache/lucene-solr/blob/faaee86efb01fa6e431fcb129cfb956c7d62d514/dev-tools/scripts/smokeTestRelease.py#L378

> Found by [~ab]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message