lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] KoenDG opened a new pull request #707: Use append() when StringBuilder is being used, instead of regular concat.
Date Sun, 09 Jun 2019 21:42:37 GMT
KoenDG opened a new pull request #707: Use append() when StringBuilder is being used, instead
of regular concat.
URL: https://github.com/apache/lucene-solr/pull/707
 
 
   This PR is related to the following ticket:
   
   https://issues.apache.org/jira/browse/SOLR-13533
   
   As stated in the ticket, this was done in my spare time, please do not review this PR during
your working hours. More details in the Jira ticket.
   
   This specific commit affects all points in the codebase where the argument of a StringBuilder.append()
call is itself a regular String concatenation.
   This defeats the purpose of using StringBuilder and also introduces an extra alloction.
   These changes should avoid that.
   
   It's a big commit, yet it's 1 automated change, performed by Intellij's static code analysis.
   
   ant tests have run, succeeded on local machine.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message