lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl <jan....@cominvent.com>
Subject Github PRs without attached JIRA issue
Date Fri, 07 Jun 2019 10:53:22 GMT
Hi,

We have some contributors that open GitHub PRs without also opening a JIRA and linking the
two. Probably because they are used to that workflow from other projects and expect someone
to have a look at the contribution. There is an email sent to the dev list, and sometimes
it is noticed, other times the PR just falls through the cracks and is forgotten.

Here is a list of currently open PRs without a JIRA attached, 51 in total:

https://github.com/apache/lucene-solr/pulls?utf8=✓&q=is%3Apr+is%3Aopen+NOT+LUCENE+in%3Atitle+AND+NOT+SOLR+in%3Atitle+

How can we improve on the situation? I see a few alternatives:

A. Setup a bot with a GitHub WebHook that inspects the title and auto adds a comment if LUCENE
or SOLR is missing
   https://developer.github.com/v3/activity/events/types/#pullrequestevent
B. Send the result of the above query to the dev@ list monthly for someone to jump in and
interact
C. Add a GitHub Pull-Request Template https://help.github.com/en/articles/creating-a-pull-request-template-for-your-repository
   In there put some text about the requirement for a JIRA
D. Treat PRs as first-class issues, without the need for a shadow JIRA. In that case, we'd
reference PRs in CHANGES too, e.g.:
   * #217: Fix bug foo
E. Migrate away from JIRA and use GitHub issues + PR instead. Some Apache projects do that
already :)

Let the discussion begin :)

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message