From dev-return-355006-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Mon May 6 06:25:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 35B1118060F for ; Mon, 6 May 2019 08:25:06 +0200 (CEST) Received: (qmail 8587 invoked by uid 500); 6 May 2019 06:25:05 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 8577 invoked by uid 99); 6 May 2019 06:25:04 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 May 2019 06:25:04 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 61A78E0F34 for ; Mon, 6 May 2019 06:25:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0D52224597 for ; Mon, 6 May 2019 06:25:00 +0000 (UTC) Date: Mon, 6 May 2019 06:25:00 +0000 (UTC) From: "Tomoko Uchida (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-8793) Enhanced UI for CustomAnalyzer : show analysis steps MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-8793?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D168= 33542#comment-16833542 ]=20 Tomoko Uchida commented on LUCENE-8793: --------------------------------------- [~jun_o]: thanks for the nice patch! I did some sanity checks locally. First of all, this works for me by the an= t target: {{ant -f lucene/luke/build.xml run}} :) I noticed a few things: 1. Javadocs linter failed, so {{ant precommit}} also failed. {code:java} -documentation-lint: [echo] checking for broken html... [jtidy] FIXME: Broken HTML checks were disabled, as jtidy can't handle = HTML5. [echo] Checking for broken links... [exec]=20 [exec] Crawl/parse... [exec]=20 [exec] Verify... [echo] Checking for missing docs... [exec]=20 [exec] build/docs/luke/org/apache/lucene/luke/app/desktop/components/f= ragments/analysis/package-summary.html [exec] missing description: SimpleAnalyzeResultPanelOperator.TokensT= ableModel [exec] missing description: SimpleAnalyzeResultPanelProvider [exec] missing description: StepByStepAnalyzeResultPanelOperator.Nam= edTokensTableModel [exec] missing description: StepByStepAnalyzeResultPanelProvider [exec]=20 [exec] Missing javadocs were found! BUILD FAILED {code} But we can delay this until all other things are done. 2. Omitting char filters is not intuitive. I think this patch is not complete without support for the charfilters, bec= ause users would expect whole analysis steps are shown in this panel. Maybe= we can show the results for char filters along with those for tokenizer/to= kenfilters by laying out the sub-panels vertically, not horizontally? (I ha= ve not yet checked the details. Just an idea.) Vertical layout may be also good when you add many filters like this: !Screenshot from 2019-05-06 13-45-40.png|width=3D724,height=3D212! In this case, I added a char filter and four token filters. !Screenshot from 2019-05-06 13-46-16.png|width=3D362,height=3D216! =C2=A0 3. "Test Analyzer Step by Step" button is visible when a "Preset" analyzer = is selected. The button does not make sense with preset analyzers, because there is alwa= ys only one step and the result is identical with "Test Analyzer". I think this button should not be visible (or at least disabled) when "Pres= et" is selected. 4. "Test Analyzer Step by Step" could be a checkbox, not a button. To me, this functionality looks like an option to change "Test Analyzer" be= haviour. So I'd use a checkbox (labeled "step-by-step", for example) to swi= tch the result panel. Do you have thoughts about this? And, I just wanted to add comments about the restriction: {quote}Current patch is only show each tokenizer/filters result independent= ly, so the result doesn't show deletion/separation by next filter, e.g. "li= brary" by WordDelimiterFilter is different position between other output. {quote} Except the support for charfilters as I noted above, it seems to be fine to= me. This can be done by another issue (in the future.) I have not yet checked the code... will do soon. > Enhanced UI for CustomAnalyzer : show analysis steps > ---------------------------------------------------- > > Key: LUCENE-8793 > URL: https://issues.apache.org/jira/browse/LUCENE-8793 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke > Reporter: Jun Ohtani > Priority: Minor > Attachments: LUCENE-8793.patch, Screen Shot 2019-05-06 at 10.00.5= 7.png, Screenshot from 2019-05-06 13-45-40.png, Screenshot from 2019-05-06 = 13-46-16.png > > > This is a migrated issue from previous Luke project in GitHub: [https://g= ithub.com/DmitryKey/luke/issues/134] > =C2=A0 > For on-the-fly inspection / debugging, it is desirable to show the more d= etailed step by step information in the Custom Analyzer UI. > This will be just like Solr's Analysis screen, > [https://lucene.apache.org/solr/guide/7_5/analysis-screen.html] > or Elasticsearch's {{_analyze}} API and Kibana's Analyzer UI. > [https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-= analyze.html] > [https://github.com/johtani/analyze-api-ui-plugin] -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org