From dev-return-354846-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Fri May 3 12:30:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C1D3D18064D for ; Fri, 3 May 2019 14:30:03 +0200 (CEST) Received: (qmail 49235 invoked by uid 500); 3 May 2019 12:30:02 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 49223 invoked by uid 99); 3 May 2019 12:30:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 May 2019 12:30:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8F71EE02EC for ; Fri, 3 May 2019 12:30:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D796724597 for ; Fri, 3 May 2019 12:30:00 +0000 (UTC) Date: Fri, 3 May 2019 12:30:00 +0000 (UTC) From: "Uwe Schindler (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-8778) Define analyzer SPI names as static final fields and document the names in Javadocs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-8778?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D168= 32463#comment-16832463 ]=20 Uwe Schindler commented on LUCENE-8778: --------------------------------------- Comments are now there. I fogot to click on "Start Review" (the mobile phon= e screens are too small to see everything!). > Define analyzer SPI names as static final fields and document the names i= n Javadocs > -------------------------------------------------------------------------= ---------- > > Key: LUCENE-8778 > URL: https://issues.apache.org/jira/browse/LUCENE-8778 > Project: Lucene - Core > Issue Type: Task > Components: modules/analysis > Reporter: Tomoko Uchida > Priority: Minor > Attachments: Screenshot from 2019-04-26 02-17-48.png > > Time Spent: 50m > Remaining Estimate: 0h > > Each built-in analysis component (factory of tokenizer / char filter / to= ken filter)=C2=A0 has a SPI name but currently this is not=C2=A0 documented= anywhere. > The goals of this issue: > * Define SPI names as static final field for each analysis component so = that users can get the component by name (via {{NAME}} static field.) This = also provides compile time safety. > * Officially document the SPI names in Javadocs. > * Add proper source validation rules to ant {{validate-source-patterns}}= target so that we can make sure that all analysis components have correct = field definitions and documentation > and, > * Lookup SPI names on the new {{NAME}} fields. Instead deriving those fr= om class names. > (Just for quick reference) we now have: > * *19* Tokenizers ({{TokenizerFactory.availableTokenizers()}}) > * *6* CharFilters ({{CharFilterFactory.availableCharFilters()}}) > * *118* TokenFilters ({{TokenFilterFactory.availableTokenFilters()}}) -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org