From dev-return-355886-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Wed May 15 21:31:07 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4F7B8180621 for ; Wed, 15 May 2019 23:31:07 +0200 (CEST) Received: (qmail 34300 invoked by uid 500); 15 May 2019 21:31:02 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 34279 invoked by uid 99); 15 May 2019 21:31:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 May 2019 21:31:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 86A37E2C00 for ; Wed, 15 May 2019 21:31:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C342A25819 for ; Wed, 15 May 2019 21:31:00 +0000 (UTC) Date: Wed, 15 May 2019 21:31:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-12999) Index replication could delete segments first MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-12999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840792#comment-16840792 ] ASF subversion and git services commented on SOLR-12999: -------------------------------------------------------- Commit bf8c6ea435a39564d2a7de5c37cc9e522ca5b9cb in lucene-solr's branch refs/heads/jira/SOLR-13468 from Chris M. Hostetter [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=bf8c6ea ] SOLR-12999: Harden TestReplicationHandlerDiskOverFlow against sporadic timing failures - ensure IndexFetcher injection is reset in @After method - replace System.out with Logger - Log and fail on any exceptions in any callbacks/threads - use CyclicBarrier (instead of CountdownLatch) to ensure the Query Thread loop doesn't monopolize CPU preventing IndexFetcher callback from ever being run (Some of these improvements directly address jenkins failures we've been seeing) > Index replication could delete segments first > --------------------------------------------- > > Key: SOLR-12999 > URL: https://issues.apache.org/jira/browse/SOLR-12999 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: replication (java) > Reporter: David Smiley > Assignee: Noble Paul > Priority: Major > Fix For: 8.1 > > Attachments: SOLR-12999.patch, SOLR-12999.patch > > > Index replication could optionally delete files that it knows will not be needed _first_. This would reduce disk capacity requirements of Solr, and it would reduce some disk fragmentation when space get tight. > Solr (IndexFetcher) already grabs the remote file list, and it could see which files it has locally, then delete the others. Today it asks Lucene to {{deleteUnusedFiles}} at the end. This new mode would probably only be useful if there is no SolrIndexSearcher open, since it would prevent the removal of files. > The motivating scenario is a SolrCloud replica that is going into full recovery. It ought to not be fielding searches. The code changes would not depend on SolrCloud though. > This option would have some danger the user should be aware of. If the replication fails, leaving the local files incomplete/corrupt, the only recourse is to try full replication again. You can't just give up and field queries. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org