From dev-return-354858-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Fri May 3 18:18:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1FF8D18064D for ; Fri, 3 May 2019 20:18:05 +0200 (CEST) Received: (qmail 88448 invoked by uid 500); 3 May 2019 18:18:03 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 88392 invoked by uid 99); 3 May 2019 18:18:03 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 May 2019 18:18:03 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A8265E2B8E for ; Fri, 3 May 2019 18:18:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 170B02581A for ; Fri, 3 May 2019 18:18:01 +0000 (UTC) Date: Fri, 3 May 2019 18:18:01 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-12833) Use timed-out lock in DistributedUpdateProcessor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-12833?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1683= 2719#comment-16832719 ]=20 ASF subversion and git services commented on SOLR-12833: -------------------------------------------------------- Commit 85c16a5e764cde5b2a31005d19aa0925deca8aba in lucene-solr's branch ref= s/heads/branch_7x from Andrzej Bialecki [ https://gitbox.apache.org/repos/asf?p=3Dlucene-solr.git;h=3D85c16a5 ] SOLR-12833: Avoid unnecessary memory cost when DistributedUpdateProcessor t= imed-out lock is not used. > Use timed-out lock in DistributedUpdateProcessor > ------------------------------------------------ > > Key: SOLR-12833 > URL: https://issues.apache.org/jira/browse/SOLR-12833 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public)=20 > Components: update, UpdateRequestProcessors > Affects Versions: 7.5, 8.0 > Reporter: jefferyyuan > Assignee: Mark Miller > Priority: Blocker > Fix For: 7.7, 8.0, 8.1 > > Attachments: SOLR-12833-noint.patch, SOLR-12833.patch, SOLR-12833= .patch, threadDump.txt > > Time Spent: 20m > Remaining Estimate: 0h > > There is a synchronize block that blocks other update requests whose IDs = fall in the same hash bucket.=C2=A0The update=C2=A0waits forever until it g= ets the lock at the=C2=A0synchronize block, this can be a problem in some c= ases. > =C2=A0 > Some add/update requests (for example updates with spatial/shape analysis= ) like may take time (30+ seconds or even more), this would the request tim= e out and fail. > Client may retry the same requests multiple times or several minutes, thi= s would make things worse. > The server side receives all the update requests but all except one can d= o nothing, have to wait there. This wastes precious memory and cpu resource= . > We have seen the case 2000+ threads are blocking at the=C2=A0synchronize = lock, and only a few=C2=A0updates are making progress. Each thread takes 3+= mb memory which causes OOM. > Also if the update can't get the lock in expected time range, its better = to fail fast. > =C2=A0 > We can have one configuration in solrconfig.xml:=C2=A0updateHandler/versi= onLock/timeInMill, so users can specify how long they want to wait the vers= ion bucket lock. > The default value can be -1, so it behaves same - wait forever until it g= ets the lock. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org