lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-13469) rejected requests during ful IndexFetch should not use 403 response code
Date Mon, 20 May 2019 17:25:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-13469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844142#comment-16844142
] 

ASF subversion and git services commented on SOLR-13469:
--------------------------------------------------------

Commit 6cc67e433e191b5c0450a4d2fc06de26939ac920 in lucene-solr's branch refs/heads/master
from Chris M. Hostetter
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=6cc67e4 ]

SOLR-13474: Fix "Search is temporarily disabled" logic to be consistent for entire request

SOLR-13469: Fix rejected requests during full disk full + IndexFetch to use 503 not 403


> rejected requests during ful IndexFetch should not use 403 response code
> ------------------------------------------------------------------------
>
>                 Key: SOLR-13469
>                 URL: https://issues.apache.org/jira/browse/SOLR-13469
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Hoss Man
>            Priority: Major
>
> SOLR-12999 introduced a new behavior where Solr nodes can now know to quickly reject
requests when the index is unavailable due to a full IndexFetch from the master/leader - but
when this change was implemented it was done soe using the HTTP status code "403" (Forbidden)
which semantically indicates a _client_ error and carries with it the understanding that the
client should not re-attempt the request ... at least not w/o modification (typically adding
authentication information)
> A more semantically correct response code would be 503 (Service Unavailable) which indicates
a _server_ problem (that may be resolved at some point in the future) and clients would not
be ill-behaved to try again later.
> returning 503 in this particular code path would also be more consistent with other places
in the solr code based where nodes respond with "503" when they are "not _currently_ ready
for requests" (but might be soon)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message