lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-8757) Better Segment To Thread Mapping Algorithm
Date Mon, 20 May 2019 18:31:01 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844198#comment-16844198
] 

Adrien Grand edited comment on LUCENE-8757 at 5/20/19 6:30 PM:
---------------------------------------------------------------

Thanks [~atris]. I think there is a bug in AssertingCollector as previousDocBase is always
-1? By the way, we don't need to ensure that previousDocBase <= docBase, but that previousDocBase
+ previousMaxDoc <= docBase?


was (Author: jpountz):
Thanks [~atris]. I think there is a bug in AssertingCollector as previousDocBase is always
1? By the way, we don't only need to ensure that previousDocBase <= docBase, but even that
previousDocBase + previousMaxDoc <= docBase?

> Better Segment To Thread Mapping Algorithm
> ------------------------------------------
>
>                 Key: LUCENE-8757
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8757
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Atri Sharma
>            Assignee: Simon Willnauer
>            Priority: Major
>         Attachments: LUCENE-8757.patch, LUCENE-8757.patch, LUCENE-8757.patch, LUCENE-8757.patch,
LUCENE-8757.patch, LUCENE-8757.patch, LUCENE-8757.patch, LUCENE-8757.patch
>
>
> The current segments to threads allocation algorithm always allocates one thread per
segment. This is detrimental to performance in case of skew in segment sizes since small segments
also get their dedicated thread. This can lead to performance degradation due to context switching
overheads.
>  
> A better algorithm which is cognizant of size skew would have better performance for
realistic scenarios



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message