lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8756) MLT queries ignore custom term frequencies
Date Wed, 01 May 2019 04:48:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830858#comment-16830858
] 

David Smiley commented on LUCENE-8756:
--------------------------------------

Some commits were not reported because the commit message didn't mention the issue:  https://github.com/apache/lucene-solr/commit/351e21f6203e8f3aece0cd5adf4049974bd2d636

BTW that commit now fails "ant precommit" although might not of at the time.  Can you please
fix this [~mikemccand]?

{noformat}
[forbidden-apis] Forbidden method invocation: java.lang.String#format(java.lang.String,java.lang.Object[])
[Uses default locale]
[forbidden-apis]   in org.apache.lucene.queries.mlt.TestMoreLikeThis (TestMoreLikeThis.java:497)
{noformat}

As an aside, I don't know why some devs like to call String.format in cases when simple/obvious
string concatenation is equivalent.

> MLT queries ignore custom term frequencies
> ------------------------------------------
>
>                 Key: LUCENE-8756
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8756
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/queryparser
>    Affects Versions: 7.0, 7.0.1, 7.1, 7.2, 7.2.1, 7.3, 7.4, 7.3.1, 7.5, 7.6, 7.7, 7.7.1,
8.0
>            Reporter: Olli Kuonanoja
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The MLT queries ignore any custom term frequencies for the like-texts and uses a hard-coded
frequency of 1 per occurrence. I have prepared a test-case to demonstrate the issue and a
fix proposal https://github.com/ollik1/lucene-solr/commit/9dbbce2af26698cec1ac82a526d9cee60a880678




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message