lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cassandra Targett (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12885) BinaryResponseWriter (javabin format) should directly copy from Bytesref to output
Date Tue, 21 May 2019 19:03:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845150#comment-16845150
] 

Cassandra Targett commented on SOLR-12885:
------------------------------------------

[~noble.paul] - here's another issue that appears in CHANGES.txt (for 7.7) but wasn't resolved,
and now is marked like it's going to be in 8.2.

*PLEASE* fix your workflow so you start resolving these in a more timely manner and accurate
fix versions.

> BinaryResponseWriter (javabin format) should directly copy from Bytesref to output
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-12885
>                 URL: https://issues.apache.org/jira/browse/SOLR-12885
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Major
>             Fix For: master (9.0), 8.2
>
>         Attachments: SOLR-12885.patch, SOLR-12885.patch, SOLR-12885.patch, SOLR-12885.patch,
SOLR-12885.patch
>
>
> The format format in which bytes are stored in {{BytesRef}} and the javabin string format
are both the same. We don't need to convert the string/text fields from {{BytesRef}} to String
and back to UTF8 
> {{Now a String/Text field is read and written out as follows}}
> {{luceneindex(UTF8 bytes) --> UTF16 (char[]) --> new String() a copy of UTF16 char[]
-->  UTF8bytes(javabin format)}}
> This does not add a new type to javabin. It's encoded as String in the serialized data.
When it is deserialized, you get a String back



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message