lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields
Date Tue, 28 May 2019 07:58:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849445#comment-16849445
] 

Adrien Grand commented on LUCENE-8362:
--------------------------------------

I had a quick look. The code organization looks good in general. However BinaryRangeFieldRangeQuery
seems to always return an empty set of docs? We should also improve tests to verify the set
of matched documents? I noticed a leftover in IntRange where the encode method becomes public
even though you are not using it?

> Add DocValue support for RangeFields 
> -------------------------------------
>
>                 Key: LUCENE-8362
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8362
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Nicholas Knize
>            Priority: Minor
>         Attachments: LUCENE-8362-approach2.patch, LUCENE-8362.patch, LUCENE-8362.patch
>
>
> I'm opening this issue to discuss adding DocValue support to {{\{Int|Long|Float|Double\}Range}}
field types. Since existing numeric range fields already provide the methods for encoding
ranges as a byte array I think this could be as simple as adding syntactic sugar to existing
range fields that simply build an instance of {{BinaryDocValues}} using that same encoding.
I'm envisioning something like {{doc.add(IntRange.newDocValuesField("intDV", 100)}} But I'd
like to solicit other ideas or potential drawbacks to this approach.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message