lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] dsmiley commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347
Date Wed, 15 May 2019 13:49:48 GMT
dsmiley commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-492662755
 
 
   It'd help to review your changes if you made fewer arbitrary changes, like adding 'final'
and changing indentation of javadocs that were fine as they were.
   Also, it'd help to summarize why 3 different issues are being fixed in one PR.  Might be
just fine but please add info/context to make reviewer's job either or you may not get a review
at all.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message