lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucene-solr] dweiss commented on issue #657: LUCENE-8781: FST direct arc addressing
Date Fri, 03 May 2019 18:56:14 GMT
dweiss commented on issue #657: LUCENE-8781: FST direct arc addressing
URL: https://github.com/apache/lucene-solr/pull/657#issuecomment-489203649
 
 
   Thanks Mike. I'll take a look and will get back to you.
   
   On Fri, May 3, 2019 at 8:46 PM Michael Sokolov <notifications@github.com>
   wrote:
   
   > *@msokolov* commented on this pull request.
   > ------------------------------
   >
   > In
   > lucene/codecs/src/java/org/apache/lucene/codecs/blocktreeords/OrdsSegmentTermsEnum.java
   > <https://github.com/apache/lucene-solr/pull/657#discussion_r280887930>:
   >
   > > @@ -1082,12 +1082,14 @@ private InputOutput getByOutput(long targetOrd) throws
IOException {
   >        if (FST.targetHasArcs(arc)) {
   >          // System.out.println("  targetHasArcs");
   >          result.grow(1+upto);
   > -
   > +        if (arc.target < 0 || arc.target > Integer.MAX_VALUE) {
   >
   > @dweiss <https://github.com/dweiss> I think I addressed your comments and
   > this is ready to be committed. If you agree, would you be able to help with
   > that (I'm not a committer, so I need help!)?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/lucene-solr/pull/657#discussion_r280887930>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AABQWLUEPKLDU5WRD5G66TTPTSCABANCNFSM4HI42KOQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message