lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cbismuth <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #495: LUCENE-8464: Implement ConstantScoreScorer#se...
Date Fri, 09 Nov 2018 09:52:58 GMT
Github user cbismuth commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/495#discussion_r232196043
  
    --- Diff: lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
    @@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws IOException {
         return score;
       }
     
    +  @Override
    +  public void setMinCompetitiveScore(float minScore) throws IOException {
    +    float minScoreDown = Math.nextDown(minScore);
    --- End diff --
    
    Thanks **a lot** for your time, these are my Lucene baby steps. I'm currently debugging
to understand why we need to add an indirection in `ConstantScoreScorer#iterator`.
    
    I understand that we need to save the current doc to not lose it. But even when I don't
save it, the indirection you suggest make the test pass and I don't understand why.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message