lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12921) Separate Solr unit tests and integration tests.
Date Thu, 25 Oct 2018 21:14:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664294#comment-16664294
] 

Mark Miller commented on SOLR-12921:
------------------------------------

bq. WDYT about changing precommit 

I think to start we just want some separating.

You want to be able to glance at a commit and understand if its adding unit tests, integration
tests, or both. There are shades of gray, but we all deal with that color constantly.

I'd prefer we had it so separate that you did ant test or ant integration test, but that's
no so important.

I think it would be most useful and least intrusive to just separate them in the source tree
initially. It would not have to be done all in one shot.

One simple idea would be that unit tests stay in the current package and integration tests
go in currentpackage.integrationtest.

I'm not sure what is best. I just know the current situation where everyone mostly just keeps
adding huge integration tests means that when they sometimes fail, no one looks at it. We
have a huge unit test deficit. This won't fix that, but it's part of a larger solution you
can see taking shape in linked JIRAs. Much better out of the box Mocks will be another piece.

> Separate Solr unit tests and integration tests.
> -----------------------------------------------
>
>                 Key: SOLR-12921
>                 URL: https://issues.apache.org/jira/browse/SOLR-12921
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>            Reporter: Mark Miller
>            Priority: Major
>
> We basically just have "tests" now. We should have separate locations for unit and integration
tests and new work should have a good reason to not include both.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message