lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-7557) Solrj doesn't handle child documents when using queryAndStreamResponse
Date Fri, 26 Oct 2018 13:57:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665208#comment-16665208
] 

ASF subversion and git services commented on SOLR-7557:
-------------------------------------------------------

Commit 6c419454a23dd8149b4dc90f8e5ad9427a2750bd in lucene-solr's branch refs/heads/master
from [~marvin.lillehaug]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6c41945 ]

SOLR-7557: Fix parsing of child documents using queryAndStreamResponse


> Solrj doesn't handle child documents when using queryAndStreamResponse
> ----------------------------------------------------------------------
>
>                 Key: SOLR-7557
>                 URL: https://issues.apache.org/jira/browse/SOLR-7557
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrJ
>    Affects Versions: 5.4
>            Reporter: Stian Østerhaug
>            Assignee: Jan Høydahl
>            Priority: Major
>             Fix For: 7.6, master (8.0)
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Getting the results from a query that as child documents results in "parsing error" when
using SolrClient's queryAndStreamResponse(), but not when using the regular query() method.
> The bug is caused by StreamingBinaryResponseParser's JavaBinCodec override of readSolrDocument
which always returns null (the document is instead passed to the callback), but JavaBinCodec
uses the method to also decode child documents.
> I have fixed this by using a simple nestedLevel variable that can be used to detect if
the document being parsed is a child (and should be returned) or a parent (and should be passed
to the callback).
> The fix feels kinda hacky, but it is simple. Link to a Github pull request to follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message