lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <>
Subject [jira] [Commented] (LUCENE-8503) Simplify unwrapping Filter*Reader
Date Mon, 17 Sep 2018 10:23:00 GMT


Simon Willnauer commented on LUCENE-8503:

I have to revert my statement. I was under the assumption that this happens in way more places
than expected. Maybe I was way too deep in it to see it all over the place. :) Nevermind.
I will change my pr to only fix the calls to instead and keep the rest like it

> Simplify unwrapping Filter*Reader
> ---------------------------------
>                 Key: LUCENE-8503
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 7.5, master (8.0)
>            Reporter: Simon Willnauer
>            Priority: Major
>             Fix For: 7.6, master (8.0)
>          Time Spent: 10m
>  Remaining Estimate: 0h
>  Today we have 3 different kinds of FilterIndexReader. While FilterDirecotryReader
>     and FilterLeafReader are simple to distinguish, FilterCodecReader make decision harder
>     since now we need instanceof checks to deside which unwrap method we should call.
>     adds a simple interface that allows to build generic unwrap methods to access the
>     of each of the filtering readers.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message