lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8484) Allow SubReaderWrapper to filter out entire readers
Date Tue, 04 Sep 2018 14:05:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603087#comment-16603087
] 

Simon Willnauer commented on LUCENE-8484:
-----------------------------------------

{quote}What happens when a segment gets removed, will there be a gap in the leaves, ie. LeafReaderContext.docBase
will be greater than LeafReaderContext.docBase + LeafReaderContext.reader().maxDoc() of the
previous leave, or will it keep dense doc IDs?
{quote}
 
it will have dense docIDs. We basically do the same thing [here|https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/StandardDirectoryReader.java#L107]

> Allow SubReaderWrapper to filter out entire readers
> ---------------------------------------------------
>
>                 Key: LUCENE-8484
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8484
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 7.5, master (8.0)
>            Reporter: Simon Willnauer
>            Priority: Minor
>             Fix For: 7.5, master (8.0)
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Today we can only wrap readers in SubReaderWrapper but never filter them out
>     entirely. This causes a invariant for soft-deletes that exposes fully deleted
>     segments with SoftDeletesDirectoryReaderWrapper. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message