lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8469) Inline calls to the deprecated StringHelper.compare
Date Wed, 29 Aug 2018 18:23:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596682#comment-16596682
] 

Dawid Weiss commented on LUCENE-8469:
-------------------------------------

Of course I inlined it automatically -- come on, I don't trust myself more than I trust software.
:)

I'll correct these and apply removal of the deprecated method in master. Thanks Adrien.

> Inline calls to the deprecated StringHelper.compare
> ---------------------------------------------------
>
>                 Key: LUCENE-8469
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8469
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 7.5
>
>         Attachments: LUCENE-8469.patch
>
>
> In an attempt to limit the number of warnings during compilation I though it'd be nice
to clean up our own stuff. This is a start: StringHelper.compare is used throughout the code
and is delegated to FutureArrays (where it belongs, as the arguments are byte[], not Strings).
> This can cause other patches to not apply anymore... so we could apply this to master
only. If anybody has a strong feeling about it, please voice it. The patch is trivial.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message