lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Sokolov <msoko...@gmail.com>
Subject Re: javadoc linting on JDK10+
Date Wed, 29 Aug 2018 17:47:01 GMT
I made this small change and it seems to work (enables javadoc linting),
not sure what other impact this mioght have though. Obviously the change is
just a WIP -- should support 9 as well, maybe 11?

diff --git a/lucene/common-build.xml b/lucene/common-build.xml
index ac4c504..c02e394 100644
--- a/lucene/common-build.xml
+++ b/lucene/common-build.xml
@@ -323,6 +323,8 @@
       <equals arg1="${-cleaned.specification.version}" arg2="1.8"/>
       <equals arg1="${-cleaned.specification.version}" arg2="1.9"/>
       <equals arg1="${-cleaned.specification.version}" arg2="9"/>
+      <equals arg1="${-cleaned.specification.version}" arg2="1.10"/>
+      <equals arg1="${-cleaned.specification.version}" arg2="10"/>
     </or>
   </condition>

@@ -2062,7 +2064,11 @@ ${ant.project.name
}.test.dependencies=${test.classpath.list}
   <!-- ECJ Javadoc linting: -->

   <condition property="ecj-javadoc-lint.supported">
-    <equals arg1="${build.java.runtime}" arg2="1.8"/>
+    <or>
+      <equals arg1="${build.java.runtime}" arg2="1.8"/>
+      <equals arg1="${build.java.runtime}" arg2="1.10"/>
+      <equals arg1="${build.java.runtime}" arg2="10"/>
+    </or>
   </condition>


On Wed, Aug 29, 2018 at 1:38 PM Michael Sokolov <msokolov@gmail.com> wrote:

> I am trying to run ant precommit (on master) and it fails for me with this
> message:
>
> -ecj-javadoc-lint-unsupported:
>
> BUILD FAILED
> /home/
> ANT.AMAZON.COM/sokolovm/workspace/lbench/lucene_baseline/lucene/common-build.xml:2076:
> Linting documentation with ECJ is not supported on this Java version
> (unknown).
>
> I think because I am using JDK10?
>
> I checked in build.xml and see this:
>
> <condition property="ecj-javadoc-lint.supported"> <equals
> arg1="${build.java.runtime}" arg2="1.8"/> </condition>
>
> does this indicate javadoc lint only works when building with JDK8?
>

Mime
View raw message