From dev-return-328983-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Tue Jul 24 19:28:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 426E1180677 for ; Tue, 24 Jul 2018 19:28:04 +0200 (CEST) Received: (qmail 93420 invoked by uid 500); 24 Jul 2018 17:28:03 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 93409 invoked by uid 99); 24 Jul 2018 17:28:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jul 2018 17:28:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A81BAC6130 for ; Tue, 24 Jul 2018 17:28:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 89bpOG5Eb03X for ; Tue, 24 Jul 2018 17:28:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6D5885F386 for ; Tue, 24 Jul 2018 17:28:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8A90BE0CB1 for ; Tue, 24 Jul 2018 17:28:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 28EE72774C for ; Tue, 24 Jul 2018 17:28:00 +0000 (UTC) Date: Tue, 24 Jul 2018 17:28:00 +0000 (UTC) From: "David Smiley (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-8426) Make ConjunctionSpans protected/public MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-8426?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D165= 54564#comment-16554564 ]=20 David Smiley commented on LUCENE-8426: -------------------------------------- I'm not sure what the semantics of a protected class might be but +1 for pu= blic and mark \@lucene.experimental. =C2=A0Some members will need to be mar= ked protected and given at least a one-liner bit of documentation. > Make ConjunctionSpans protected/public > -------------------------------------- > > Key: LUCENE-8426 > URL: https://issues.apache.org/jira/browse/LUCENE-8426 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search > Reporter: Hari Menon > Priority: Major > > ConjunctionSpans is currently package-private. This means if I want to wr= ite a custom Spans implementation that can use it, I need to basically copy= the class. If there is not good reason to keep it restricted to package, I= would like to make it protected, or even public. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org