lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8426) Make ConjunctionSpans protected/public
Date Tue, 24 Jul 2018 17:28:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554564#comment-16554564
] 

David Smiley commented on LUCENE-8426:
--------------------------------------

I'm not sure what the semantics of a protected class might be but +1 for public and mark \@lucene.experimental.
 Some members will need to be marked protected and given at least a one-liner bit of documentation.

> Make ConjunctionSpans protected/public
> --------------------------------------
>
>                 Key: LUCENE-8426
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8426
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Hari Menon
>            Priority: Major
>
> ConjunctionSpans is currently package-private. This means if I want to write a custom
Spans implementation that can use it, I need to basically copy the class. If there is not
good reason to keep it restricted to package, I would like to make it protected, or even public.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message