From dev-return-325969-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Tue Jun 19 20:31:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7DA2D18067A for ; Tue, 19 Jun 2018 20:31:05 +0200 (CEST) Received: (qmail 52196 invoked by uid 500); 19 Jun 2018 18:31:03 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 51814 invoked by uid 99); 19 Jun 2018 18:31:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Jun 2018 18:31:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1CFE3C02AB for ; Tue, 19 Jun 2018 18:31:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id kDhFkxM120rn for ; Tue, 19 Jun 2018 18:31:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 872C25F2C2 for ; Tue, 19 Jun 2018 18:31:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CE52BE0C25 for ; Tue, 19 Jun 2018 18:31:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6B33221832 for ; Tue, 19 Jun 2018 18:31:00 +0000 (UTC) Date: Tue, 19 Jun 2018 18:31:00 +0000 (UTC) From: "Gus Heck (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-11654) TimePartitionedUpdateProcessor.lookupShardLeaderOfCollection should route to the ideal shard MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-11654?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1651= 7404#comment-16517404 ]=20 Gus Heck commented on SOLR-11654: --------------------------------- The other additions were syntactic sugar, so whatever folks think there is = fine. It just seemed to me that varargs was likely just something nobody bo= thered to add yet, though certainly it's great to discuss all of this. For = the method that you pasted above I agree.=C2=A0It would be a good=C2=A0idea= to make a copy of the params and note that in the javadoc for clarity. I'm= not so sure about setting the type to SolrParams however since we then hav= e to add error logic to account for the fact that seParams takes a Modifiab= leSolrParams > TimePartitionedUpdateProcessor.lookupShardLeaderOfCollection should route= to the ideal shard > -------------------------------------------------------------------------= ------------------- > > Key: SOLR-11654 > URL: https://issues.apache.org/jira/browse/SOLR-11654 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public)=20 > Components: SolrCloud > Reporter: David Smiley > Assignee: David Smiley > Priority: Major > Attachments: SOLR-11654.patch, SOLR-11654.patch, SOLR-11654.patch > > > {{TimePartitionedUpdateProcessor.lookupShardLeaderOfCollection}} looks up= the Shard/Slice to talk to for the given collection. It currently picks t= he first active Shard/Slice but it has a TODO to route to the ideal one bas= ed on the router configuration of the target collection. There is similar = code in CloudSolrClient & DistributedUpdateProcessor that should probably b= e refactored/standardized so that we don't have to repeat this logic. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org