lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field
Date Sat, 02 Jun 2018 11:47:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499019#comment-16499019
] 

Simon Willnauer commented on LUCENE-8335:
-----------------------------------------

[~dnhatn] I had an error porting this to branch_7x


{noformat}
 [junit4] Suite: org.apache.lucene.index.TestIndexingSequenceNumbers
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestIndexingSequenceNumbers
-Dtests.method=testStressUpdateSameID -Dtests.seed=8A6CEEA00F01526D -Dtests.slow=true -Dtests.badapples=true
-Dtests.locale=fr-CH -Dtests.timezone=America/Santarem -Dtests.asserts=true -Dtests.file.encoding=UTF-8
   [junit4] ERROR   2.73s J1 | TestIndexingSequenceNumbers.testStressUpdateSameID <<<
   [junit4]    > Throwable #1: java.lang.IllegalArgumentException: this index has [___soft_deletes]
as soft-deletes already but soft-deletes field is not configured in IWC
   [junit4]    > 	at __randomizedtesting.SeedInfo.seed([8A6CEEA00F01526D:9BE73AE3C68F28BA]:0)
   [junit4]    > 	at org.apache.lucene.index.FieldInfos$FieldNumbers.addOrGet(FieldInfos.java:283)
   [junit4]    > 	at org.apache.lucene.index.FieldInfos$Builder.addOrUpdateInternal(FieldInfos.java:428)
   [junit4]    > 	at org.apache.lucene.index.FieldInfos$Builder.add(FieldInfos.java:459)
   [junit4]    > 	at org.apache.lucene.index.ParallelLeafReader.<init>(ParallelLeafReader.java:132)
   [junit4]    > 	at org.apache.lucene.index.ParallelCompositeReader$1.<init>(ParallelCompositeReader.java:126)
   [junit4]    > 	at org.apache.lucene.index.ParallelCompositeReader.prepareLeafReaders(ParallelCompositeReader.java:126)
   [junit4]    > 	at org.apache.lucene.index.ParallelCompositeReader.<init>(ParallelCompositeReader.java:72)
   [junit4]    > 	at org.apache.lucene.index.ParallelCompositeReader.<init>(ParallelCompositeReader.java:65)
   [junit4]    > 	at org.apache.lucene.index.ParallelCompositeReader.<init>(ParallelCompositeReader.java:59)
   [junit4]    > 	at org.apache.lucene.util.LuceneTestCase.wrapReader(LuceneTestCase.java:1674)
   [junit4]    > 	at org.apache.lucene.util.LuceneTestCase.maybeWrapReader(LuceneTestCase.java:1739)
   [junit4]    > 	at org.apache.lucene.util.LuceneTestCase.newSearcher(LuceneTestCase.java:1864)
   [junit4]    > 	at org.apache.lucene.util.LuceneTestCase.newSearcher(LuceneTestCase.java:1849)
   [junit4]    > 	at org.apache.lucene.util.LuceneTestCase.newSearcher(LuceneTestCase.java:1841)
   [junit4]    > 	at org.apache.lucene.index.TestIndexingSequenceNumbers.testStressUpdateSameID(TestIndexingSequenceNumbers.java:127)
   [junit4]    > 	at java.lang.Thread.run(Thread.java:748)
   [junit4]   2> NOTE: test params are: codec=Lucene70, sim=RandomSimilarity(queryNorm=false):
{id=DFR I(n)2}, locale=fr-CH, timezone=America/Santarem
   [junit4]   2> NOTE: Mac OS X 10.13.4 x86_64/Oracle Corporation 1.8.0_144 (64-bit)/cpus=4,threads=1,free=195407280,total=334495744
   [junit4]   2> NOTE: All tests run in this JVM: [TestBooleanScorer, TestParallelCompositeReader,
TestForTooMuchCloning, TestCheckIndex, TestFilterIterator, TestTermScorer, TestFutureObjects,
TestAllFilesHaveChecksumFooter, TestSoftDeletesDirectoryReaderWrapper, TestUniqueTermCount,
TestFixedBitSet, TestIndexWriterOutOfFileDescriptors, TestPointQueries, TestCrashCausesCorruptIndex,
TestGraphTokenStreamFiniteStrings, TestSortedSetSelector, TestIndexWriterMergePolicy, TestByteSlices,
TestCustomNorms, TestExceedMaxTermLength, TestMultiThreadTermVectors, TestLongValuesSource,
TestByteArrayDataInput, TestForceMergeForever, TestSegmentReader, TestMixedDocValuesUpdates,
TestSparseFixedBitSet, TestSortedSetDocValues, TestSpanBoostQuery, TestReqExclBulkScorer,
TestOmitTf, TestPendingDeletes, TestPendingSoftDeletes, Test4GBStoredFields, TestSimpleAttributeImpl,
TestAtomicUpdate, TestRAMDirectory, TestIndexedDISI, TestTimSorterWorstCase, TestPriorityQueue,
TestLiveFieldValues, TestSpanExplanations, TestOmitPositions, TestIndexWriterDelete, TestTotalHitCountCollector,
TestMatchNoDocsQuery, TestDocValuesScoring, TestForUtil, TestNIOFSDirectory, TestDemo, TestLucene70NormsFormat,
TestCloseableThreadLocal, TestDoubleRangeFieldQueries, LimitedFiniteStringsIteratorTest, TestLucene70SegmentInfoFormat,
TestIndexWriterOnDiskFull, TestBufferedIndexInput, TestTermRangeQuery, TestMultiTermConstantScore,
TestPrefixCodedTerms, TestOfflineSorter, TestSortedNumericSortField, TestIndexWriterDeleteByQuery,
TestSpans, TestFlushByRamOrCountsPolicy, TestFeatureField, TestLucene50TermVectorsFormat,
TestLongPostings, TestFuzzyQuery, TestTermsEnum2, TestMergeRateLimiter, TestGraphTokenizers,
TestCustomTermFreq, TestCharsRef, TestConcurrentMergeScheduler, TestDocValues, TestMaxPosition,
TestWildcard, TestOperations, TestIndexingSequenceNumbers]
{noformat}

can you take another look. I will revert the change to master for now.
 

> Do not allow changing soft-deletes field
> ----------------------------------------
>
>                 Key: LUCENE-8335
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8335
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 7.4, master (8.0)
>            Reporter: Nhat Nguyen
>            Assignee: Simon Willnauer
>            Priority: Minor
>         Attachments: LUCENE-8335.patch, LUCENE-8335.patch
>
>
> Today we do not enforce an index to use a single soft-deletes field. A user can create
an index with one soft-deletes field then open an IW with another field or add an index with
a different soft-deletes field. This should not be allowed and reported the error to users
as soon as possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message