lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12362) JSON and XML loaders should save the relationship of children
Date Wed, 06 Jun 2018 16:36:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503557#comment-16503557
] 

David Smiley commented on SOLR-12362:
-------------------------------------

Here's my thought-process:  If we use a request param it provides maximum flexibility.  Lets
think of the name more; naming is hard.  "addChildDocsAnon"?  Maybe "legacyChildDocs" to convey
it's old?  This assumes the current "anonymous" nature is going to go away eventually.  I
suspect the majority of current apps could add docs with the new _labelled_ form and everything
would work fine.  In the end, we're just going to add some fields and eventually leverage
that information in search.  If this really is legacy and if it's probably harmless to clients
to use the new way, then this suggests to use luceneMatchVersion instead of a parameter. 
e.g. {{getSolrConfig().luceneMatchVersion.onOrAfter(Version.LUCENE_7_4_0)}}

> JSON and XML loaders should save the relationship of children
> -------------------------------------------------------------
>
>                 Key: SOLR-12362
>                 URL: https://issues.apache.org/jira/browse/SOLR-12362
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: mosh
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Once _childDocuments in SolrInputDocument is changed to a Map, the JsonLoader and XmlLoader
should add the child document to the map while saving its key name, to maintain the child's
relationship to its parent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message