lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nhat Nguyen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs
Date Fri, 01 Jun 2018 02:17:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497476#comment-16497476
] 

Nhat Nguyen commented on LUCENE-8165:
-------------------------------------

[~rcmuir] I continued your initial patch and completed the first round which removes all
Arrays#copyOfRange usages. I will do another round for Arrays#copyOf. Could you please have
a look? Thank you!

> ban Arrays.copyOfRange with forbidden APIs
> ------------------------------------------
>
>                 Key: LUCENE-8165
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8165
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Priority: Major
>         Attachments: LUCENE-8165_copy_of_range.patch, LUCENE-8165_start.patch, LUCENE-8165_start.patch
>
>
> This method is no good, because instead of throwing AIOOBE for bad bounds, it will silently
fill with zeros (essentially silent corruption). Unfortunately it is used in quite a few places
so replacing it with e.g. arrayCopy may uncover some interesting surprises.
> See LUCENE-8164 for motivation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message