From dev-return-323325-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Thu May 24 19:06:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 89D9D180679 for ; Thu, 24 May 2018 19:06:03 +0200 (CEST) Received: (qmail 63484 invoked by uid 500); 24 May 2018 17:06:02 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 63450 invoked by uid 99); 24 May 2018 17:06:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 May 2018 17:06:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id F1F68C00D5 for ; Thu, 24 May 2018 17:06:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Vi7ckGdw6gw0 for ; Thu, 24 May 2018 17:06:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 04FDA5F419 for ; Thu, 24 May 2018 17:06:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 95895E062E for ; Thu, 24 May 2018 17:06:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2E98B21096 for ; Thu, 24 May 2018 17:06:00 +0000 (UTC) Date: Thu, 24 May 2018 17:06:00 +0000 (UTC) From: "Erick Erickson (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-8330) Detach IndexWriter from MergePolicy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489402#comment-16489402 ] Erick Erickson commented on LUCENE-8330: ---------------------------------------- Thanks, I saw this go by and said "Noooooooooooo!" ;). I figure that by the time I'm ready to check in 7976 this one will be in and I'll have to reconcile the differences, particularly in the tests. May come back for advice then... > Detach IndexWriter from MergePolicy > ----------------------------------- > > Key: LUCENE-8330 > URL: https://issues.apache.org/jira/browse/LUCENE-8330 > Project: Lucene - Core > Issue Type: Improvement > Affects Versions: 7.4, master (8.0) > Reporter: Simon Willnauer > Priority: Major > Fix For: 7.4, master (8.0) > > Attachments: LUCENE-8330.patch, LUCENE-8330.patch, LUCENE-8330.patch > > > This change introduces a new MergePolicy.MergeContext interface > that is easy to mock and cuts over all instances of IW to MergeContext. > Since IW now implements MergeContext the cut over is straight forward. > This reduces the exposed API available in MP dramatically and allows > efficient testing without relying on IW to improve the coverage and > testability of our MP implementations. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org