From dev-return-322500-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Thu May 17 09:10:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EAC3A180634 for ; Thu, 17 May 2018 09:10:04 +0200 (CEST) Received: (qmail 85025 invoked by uid 500); 17 May 2018 07:10:03 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 85015 invoked by uid 99); 17 May 2018 07:10:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 May 2018 07:10:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 73F581802E5 for ; Thu, 17 May 2018 07:10:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id f8YLaI49_2q5 for ; Thu, 17 May 2018 07:10:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6E1A25F1B9 for ; Thu, 17 May 2018 07:10:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C6FEFE0016 for ; Thu, 17 May 2018 07:10:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2215321298 for ; Thu, 17 May 2018 07:10:00 +0000 (UTC) Date: Thu, 17 May 2018 07:10:00 +0000 (UTC) From: "Georg Sorst (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-12367?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1647= 8639#comment-16478639 ]=20 Georg Sorst commented on SOLR-12367: ------------------------------------ I just noticed the same also happens when setting the weight of an (existin= g) feature to an integer instead of a float, ie. =C2=A0 {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'= --data-binary '}} { {{=C2=A0 "class": "org.apache.solr.ltr.model.LinearModel",}} {{=C2=A0 "name": "myModel",}} {{=C2=A0 "features": [ \{"name": "whatever" }],}} {{=C2=A0 "params": {"weights": {"whatever": 1}}}} {{}' -H 'Content-type:application/json'}} =C2=A0 will also throw "Model type does not exist=C2=A0{{org.apache.solr.ltr.model= .LinearModel}}". If you change the weight to 1.0 it will work fine (if the = feature "whatever" exists). > When adding a model referencing a non-existent feature the error message = is very ambiguous > -------------------------------------------------------------------------= ----------------- > > Key: SOLR-12367 > URL: https://issues.apache.org/jira/browse/SOLR-12367 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public)=20 > Components: contrib - LTR > Affects Versions: 7.3.1 > Reporter: Georg Sorst > Priority: Minor > > When adding a model that references a non-existent feature a very ambiguo= us error message is thrown, something like "Model type does not exist org.a= pache.solr.ltr.model.{{LinearModel}}". > =C2=A0 > To reproduce, do not add any features and just add a model, for example b= y doing this: > =C2=A0 > {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-stor= e' --data-binary '}} > { > {{=C2=A0 "class": "org.apache.solr.ltr.model.LinearModel",}} > {{=C2=A0 "name": "myModel",}} > {{=C2=A0 "features": [ \{"name": "whatever" }],}} > {{=C2=A0 "params": {"weights": {"whatever": 1.0}}}} > {{}' -H 'Content-type:application/json'}} > =C2=A0 > The resulting error message "Model type does not exist=C2=A0{{org.apache.= solr.ltr.model.LinearModel" is extremely misleading and cost me a while to = figure out the actual cause.}} > =C2=A0 > A more suitable error message should probably indicate the name of the mi= ssing feature that the model is trying to reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org