From dev-return-322698-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Fri May 18 18:50:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 09939180648 for ; Fri, 18 May 2018 18:50:03 +0200 (CEST) Received: (qmail 53813 invoked by uid 500); 18 May 2018 16:50:02 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 53803 invoked by uid 99); 18 May 2018 16:50:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 May 2018 16:50:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3D2CBC045F for ; Fri, 18 May 2018 16:50:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Kb0qXwoqZX03 for ; Fri, 18 May 2018 16:50:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1C49B5F356 for ; Fri, 18 May 2018 16:50:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 504A6E00C4 for ; Fri, 18 May 2018 16:50:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0B7BA2179F for ; Fri, 18 May 2018 16:50:00 +0000 (UTC) Date: Fri, 18 May 2018 16:50:00 +0000 (UTC) From: "David Smiley (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-12337) Remove QueryWrapperFilter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-12337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480896#comment-16480896 ] David Smiley commented on SOLR-12337: ------------------------------------- That TODO RE getProcessedFilter is a new issue I filed: SOLR-12375 > Remove QueryWrapperFilter > ------------------------- > > Key: SOLR-12337 > URL: https://issues.apache.org/jira/browse/SOLR-12337 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Reporter: David Smiley > Assignee: David Smiley > Priority: Major > Attachments: SOLR-12337.patch > > > QueryWrapperFilter has not been needed ever since Filter was changed to extend Query -- LUCENE-1518. It was retained because there was at least one place in Lucene that had a Filter/Query distinction, but it was forgotten when Filter moved to Solr. It contains some code that creates a temporary IndexSearcher but forgets to null out the cache on it, and so QueryWrapperFilter can add non-trivial overhead. We should simply remove it altogether. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org