From dev-return-321127-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Fri May 4 23:56:59 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B9358180634 for ; Fri, 4 May 2018 23:56:58 +0200 (CEST) Received: (qmail 68351 invoked by uid 500); 4 May 2018 21:56:57 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 68341 invoked by uid 99); 4 May 2018 21:56:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 May 2018 21:56:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 5B581C05EA for ; Fri, 4 May 2018 21:56:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.69 X-Spam-Level: X-Spam-Status: No, score=0.69 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id BEQpKxhPyFUd for ; Fri, 4 May 2018 21:56:55 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id ABF0F5F59D for ; Fri, 4 May 2018 21:56:54 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4BA85E00D3; Fri, 4 May 2018 21:56:54 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0B3DAC4022C; Fri, 4 May 2018 21:56:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6490638990405803621==" MIME-Version: 1.0 Subject: Re: Review Request 66967: SolrCmdDistributor retries requestss from leader to followers From: =?utf-8?b?VG9tw6FzIEZlcm7DoW5kZXogTMO2YmJl?= To: =?utf-8?b?VG9tw6FzIEZlcm7DoW5kZXogTMO2YmJl?= , Varun Thacker , lucene Date: Fri, 04 May 2018 21:56:54 -0000 Message-ID: <20180504215654.31648.71845@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: =?utf-8?b?VG9tw6FzIEZlcm7DoW5kZXogTMO2YmJlIDxub3JlcGx5QHJldmlld3Mu?=@reviews.apache.org, =?utf-8?q?apache=2Eorg=3E?=@reviews.apache.org X-ReviewGroup: lucene X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66967/ X-Sender: =?utf-8?b?VG9tw6FzIEZlcm7DoW5kZXogTMO2YmJlIDxub3JlcGx5QHJldmll?= =?utf-8?q?ws=2Eapache=2Eorg=3E?= References: <20180504211138.31647.4837@reviews-vm2.apache.org> In-Reply-To: <20180504211138.31647.4837@reviews-vm2.apache.org> Reply-To: =?utf-8?b?VG9tw6FzIEZlcm7DoW5kZXogTMO2YmJlIDx0ZmxvYmJlQGFwYWNo?=@reviews.apache.org, =?utf-8?b?ZS5vcmc+?=@reviews.apache.org X-ReviewRequest-Repository: lucene-solr --===============6490638990405803621== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On May 4, 2018, 9:11 p.m., Varun Thacker wrote: > > solr/core/src/test/org/apache/solr/update/MockStreamingSolrClients.java > > Line 28 (original) > > > > > > We can use @LogLevel("org.apache.solr.update.SolrCmdDistributor=DEBUG) for this test to make it easier to check manually if the retires are happening or not . This would avoid changing the log4j2.xml file Thanks! I didn't know that existed. - Tomás ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66967/#review202485 ----------------------------------------------------------- On May 4, 2018, 7:49 p.m., Tomás Fernández Löbbe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66967/ > ----------------------------------------------------------- > > (Updated May 4, 2018, 7:49 p.m.) > > > Review request for lucene. > > > Repository: lucene-solr > > > Description > ------- > > Still need to do some more testing. Won't be committing the log4j changes > > > Diffs > ----- > > solr/core/src/java/org/apache/solr/update/SolrCmdDistributor.java 08b397fbb2 > solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java d5e4194b15 > solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java 224bd4b6ba > solr/core/src/test-files/log4j2.xml 7d0ebf7a49 > solr/core/src/test/org/apache/solr/update/MockStreamingSolrClients.java 72d39ff89b > solr/core/src/test/org/apache/solr/update/SolrCmdDistributorTest.java 1699b0d70d > > > Diff: https://reviews.apache.org/r/66967/diff/1/ > > > Testing > ------- > > > Thanks, > > Tomás Fernández Löbbe > > --===============6490638990405803621== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66967/

On May 4th, 2018, 9:11 p.m. UTC, Varun Thacker wrote:

solr/core/src/test/org/apache/solr/update/MockStreamingSolrClients.java (Diff revision 1)
28 

    
    

  


 




  
We can use @LogLevel("org.apache.solr.update.SolrCmdDistributor=DEBUG) for this test to make it easier to check manually if the retires are happening or not . This would avoid changing the log4j2.xml file

 









Thanks! I didn't know that existed.








- Tomás






On May 4th, 2018, 7:49 p.m. UTC, Tomás Fernández Löbbe wrote:











 

  


Review request for lucene.


By Tomás Fernández Löbbe.




Updated May 4, 2018, 7:49 p.m.












 Repository: 
lucene-solr





Description 

 

 

  
   
Still need to do some more testing. Won't be committing the log4j changes

  		
 









Diffs 


    

 
  • solr/core/src/java/org/apache/solr/update/SolrCmdDistributor.java (08b397fbb2)
    • 

 
  • solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java (d5e4194b15)
    • 

 
  • solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java (224bd4b6ba)
    • 

 
  • solr/core/src/test-files/log4j2.xml (7d0ebf7a49)
    • 

 
  • solr/core/src/test/org/apache/solr/update/MockStreamingSolrClients.java (72d39ff89b)
    • 

 
  • solr/core/src/test/org/apache/solr/update/SolrCmdDistributorTest.java (1699b0d70d)
    • 






View Diff











  		
 










  

 



--===============6490638990405803621==--