lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8341) Record soft deletes in SegmentCommitInfo
Date Thu, 31 May 2018 15:20:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496701#comment-16496701
] 

Michael McCandless commented on LUCENE-8341:
--------------------------------------------

+1

Maybe add javadocs for the new {{DocConsumer.getHasDocValues}}?

Why did you need the {{SoftDeletesFilterCodecReader}}?

Can we also fix {{CheckIndex}} to verify the soft delete count?  Hmm I guess we cannot until/unless
we record the soft deletes field in the index (LUCENE-8335).

Do we have a test case that verifies the {{softDelCount}} after new soft deletes (by applying
DV updates)?

>  Record soft deletes in SegmentCommitInfo
> -----------------------------------------
>
>                 Key: LUCENE-8341
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8341
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 7.4, master (8.0)
>            Reporter: Simon Willnauer
>            Priority: Major
>             Fix For: 7.4, master (8.0)
>
>         Attachments: LUCENE-8341.patch, LUCENE-8341.patch
>
>
>  This change add the number of documents that are soft deletes but
>     not hard deleted to the segment commit info. This is the last step
>     towards making soft deletes as powerful as hard deltes since now the
>     number of document can be read from commit points without opening a
>     full blown reader. This also allows merge posliies to make decisions
>     without requiring an NRT reader to get the relevant statistics. This
>     change doesn't enforce any field to be used as soft deletes and the statistic
>     is maintained per segment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message