lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8330) Detach IndexWriter from MergePolicy
Date Thu, 24 May 2018 18:52:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489585#comment-16489585
] 

Simon Willnauer commented on LUCENE-8330:
-----------------------------------------

 
{quote}Seeing the live deletes has been really helpful in the past, but I agree it's an awkward
addition on the interface, so +1 to keep it out.{quote}
 
I can add this:
{noformat}
/**
 * Returns the number of deleted documents in the given segments.
 */
 int numDeletedDocs(SegmentCommitInfo info);
{noformat}

to the interface to have a accurate stats. I think that is less awkward and helpful, WDYT
[~mikemccand]

> Detach IndexWriter from MergePolicy
> -----------------------------------
>
>                 Key: LUCENE-8330
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8330
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 7.4, master (8.0)
>            Reporter: Simon Willnauer
>            Priority: Major
>             Fix For: 7.4, master (8.0)
>
>         Attachments: LUCENE-8330.patch, LUCENE-8330.patch, LUCENE-8330.patch
>
>
>  This change introduces a new MergePolicy.MergeContext interface
>     that is easy to mock and cuts over all instances of IW to MergeContext.
>     Since IW now implements MergeContext the cut over is straight forward.
>     This reduces the exposed API available in MP dramatically and allows
>     efficient testing without relying on IW to improve the coverage and
>     testability of our MP implementations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message