lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <>
Subject [jira] [Commented] (LUCENE-8330) Detach IndexWriter from MergePolicy
Date Thu, 24 May 2018 18:52:00 GMT


Simon Willnauer commented on LUCENE-8330:

{quote}Seeing the live deletes has been really helpful in the past, but I agree it's an awkward
addition on the interface, so +1 to keep it out.{quote}
I can add this:
 * Returns the number of deleted documents in the given segments.
 int numDeletedDocs(SegmentCommitInfo info);

to the interface to have a accurate stats. I think that is less awkward and helpful, WDYT

> Detach IndexWriter from MergePolicy
> -----------------------------------
>                 Key: LUCENE-8330
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 7.4, master (8.0)
>            Reporter: Simon Willnauer
>            Priority: Major
>             Fix For: 7.4, master (8.0)
>         Attachments: LUCENE-8330.patch, LUCENE-8330.patch, LUCENE-8330.patch
>  This change introduces a new MergePolicy.MergeContext interface
>     that is easy to mock and cuts over all instances of IW to MergeContext.
>     Since IW now implements MergeContext the cut over is straight forward.
>     This reduces the exposed API available in MP dramatically and allows
>     efficient testing without relying on IW to improve the coverage and
>     testability of our MP implementations.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message