lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8330) Detach IndexWriter from MergePolicy
Date Thu, 24 May 2018 17:06:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489402#comment-16489402
] 

Erick Erickson commented on LUCENE-8330:
----------------------------------------

Thanks, I saw this go by and said "Noooooooooooo!" ;). I figure that by the time I'm ready
to check in 7976 this one will be in and I'll have to reconcile the differences, particularly
in the tests. May come back for advice then...


> Detach IndexWriter from MergePolicy
> -----------------------------------
>
>                 Key: LUCENE-8330
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8330
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 7.4, master (8.0)
>            Reporter: Simon Willnauer
>            Priority: Major
>             Fix For: 7.4, master (8.0)
>
>         Attachments: LUCENE-8330.patch, LUCENE-8330.patch, LUCENE-8330.patch
>
>
>  This change introduces a new MergePolicy.MergeContext interface
>     that is easy to mock and cuts over all instances of IW to MergeContext.
>     Since IW now implements MergeContext the cut over is straight forward.
>     This reduces the exposed API available in MP dramatically and allows
>     efficient testing without relying on IW to improve the coverage and
>     testability of our MP implementations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message