lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christine Poerschke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12395) Typo in SignificantTermsQParserPlugin.NAME
Date Tue, 29 May 2018 17:43:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493931#comment-16493931
] 

Christine Poerschke commented on SOLR-12395:
--------------------------------------------

Thanks [~kaessmann] for the new patch which includes a new {{SignificantTermsQParserPluginTest}}
class. I'm attaching variant of it that swaps the argument order for the {{assertEquals}}
calls, on the assumption that {{QParserPlugin.standardPlugins.get(...)}} and {{SignificantTermsQParserPlugin.NAME}}
are what is tested i.e. the {{actual}}s. Does that make sense or did I misunderstand the test
logic?

bq. ... couldn't use the constant in the SignificantTermsStream, because of the missing solr-core
dependency ...

That's correct.

Also changing ticket status to 'Patch Available' for Lucene/Solr QA 'bot to add its input.

> Typo in SignificantTermsQParserPlugin.NAME
> ------------------------------------------
>
>                 Key: SOLR-12395
>                 URL: https://issues.apache.org/jira/browse/SOLR-12395
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: query parsers
>    Affects Versions: 6.5, 7.3.1
>            Reporter: Tobias Kässmann
>            Priority: Trivial
>         Attachments: SOLR-12395.patch, SOLR-12395.patch
>
>
> I think there is a small typo in the {{SignificantTermsQParserPlugin}}:
> {code:java}
> public static final String NAME = "sigificantTerms";{code}
> should be:
> {code:java}
> public static final String NAME = "significantTerms";{code}
>  See the patch attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message