lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christine Poerschke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12395) Typo in Sigificant Terms
Date Thu, 24 May 2018 19:17:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489629#comment-16489629
] 

Christine Poerschke commented on SOLR-12395:
--------------------------------------------

Good catch! I wonder if for {{branch_7x}} (but not {{master}}) we might wanna preserve backwards
compatibility via something like
{code}
   map.put(SignificantTermsQParserPlugin.NAME, SignificantTermsQParserPlugin.class);
+  map.put("sigificantTerms", SignificantTermsQParserPlugin.class); // for Solr 7.x backcompat
only
{code}

in [QParserPlugin|https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.3.1/solr/core/src/java/org/apache/solr/search/QParserPlugin.java#L83]
so that anyone currently using the parser name with the typo can more easily transition to
the new name?

cc [~joel.bernstein] [~dsmiley]

> Typo in Sigificant Terms
> ------------------------
>
>                 Key: SOLR-12395
>                 URL: https://issues.apache.org/jira/browse/SOLR-12395
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: query parsers
>    Affects Versions: 7.3.1
>            Reporter: Tobias Kässmann
>            Priority: Trivial
>         Attachments: SOLR-12395.patch
>
>
> I think there is a small typo in the {{SignificantTermsQParserPlugin}}:
> {code:java}
> public static final String NAME = "sigificantTerms";{code}
> should be:
> {code:java}
> public static final String NAME = "significantTerms";{code}
>  See the patch attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message