lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <>
Subject [jira] [Commented] (LUCENE-8316) Allow DV updates for not existing fields
Date Wed, 16 May 2018 13:20:00 GMT


Adrien Grand commented on LUCENE-8316:

It looks good to me. Maybe we should also test explicitly what happens when the field already
exists but doesn't have doc values, and what happens if you do a doc-value update but none
of the fields have doc values yet (so the doc values producer of the segment will be null).

> Allow DV updates for not existing fields
> ----------------------------------------
>                 Key: LUCENE-8316
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 7.4, master (8.0)
>            Reporter: Simon Willnauer
>            Priority: Major
>             Fix For: 7.4, master (8.0)
>         Attachments: LUCENE-8316.patch
>  Today we prevent DV updates for non-existing fields except
>     of the soft deletes case. Yet, this can cause inconsitent field numbers
>     etc. since we don't go through the global field number map etc. This
>     change removes the limitation of updating DVs in docs even if the field
>     doesn't exists. This also has the benefit that the error messages if
>     the field type doesn't match is consistent with what DWPT throws.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message