lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <>
Subject [jira] [Commented] (SOLR-12361) Change _childDocuments to Map
Date Thu, 24 May 2018 04:26:00 GMT


David Smiley commented on SOLR-12361:

I looked closer at what it would take to remove the direct flattening.  AddUpdateCommand would
no longer implement Iterable<Document>.  DirectUpdateHandler2.allowDuplicateUpdate currently
grabs this iterable and passes to Lucene IndexWriter.  I think it could instead grab a List<Document>
from the command, after which it could then check the size for > 1 and add one document
or the set of them atomically (no need for cmd.isBlock).  Maybe I'll look at this more tomorrow.
 So this could remove the isBlock call which is potentially expensive'ish.  We could even
do this and leave DocumentBuilder alone; keep the flatten.  Shrug; eh; debatable... 

> Change _childDocuments to Map
> -----------------------------
>                 Key: SOLR-12361
>                 URL:
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: mosh
>            Priority: Major
>         Attachments: SOLR-12361.patch, SOLR-12361.patch
>          Time Spent: 50m
>  Remaining Estimate: 0h
> During the discussion on SOLR-12298, there was a proposal to change _childDocuments in
SolrDocumentBase to a Map, to incorporate the relationship between the parent and its child

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message