lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12361) Change _childDocuments to Map
Date Thu, 24 May 2018 04:04:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488384#comment-16488384
] 

David Smiley commented on SOLR-12361:
-------------------------------------

I mostly finished reviewing #382 (removal of \_childDocuments) but I ought to look a bit more;
plus I need to look at your #2 path.  As I was looking at #382, I kept thinking of back-compat
ramifications, and then an epiphany hit me:  Lets say that docs can have semantic child
relations (named child relations), *OR* (XOR?) they can have anonymous ones -- what we have
today.  The latter (anonymous), lets say we retain this for now in 7x (keep \_childDocuments
impl) but come 8.0 we remove it.  For now just leave it and we deal with child docs potentially in
both places.  In this scheme, doc.getChildDocuments only returns anonymous children (impl
doesn't change).  We can't change the name unfortunately but we can add javadocs that scream
this point and potentially mark itself deprecated.  With this path, the main thing to concern
ourselves with right now is simply supporting SolrInputDocument as field values and not worrying
about disturbing back-compat.  This means we also needn't worry about, say, your change to
ClientUtils.writeXML since child docs can come from either place and it's okay (no duplication
of same docs to worry about).

Also, I wonder if we even need to directly "flatten" the tree to a List after all?  Consider
your change to DocumentBuilder; maybe it should just operate recursively?  Granted DocumentBuilder
would then need to return a List<Document> but whatever.

> Change _childDocuments to Map
> -----------------------------
>
>                 Key: SOLR-12361
>                 URL: https://issues.apache.org/jira/browse/SOLR-12361
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: mosh
>            Priority: Major
>         Attachments: SOLR-12361.patch, SOLR-12361.patch
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> During the discussion on SOLR-12298, there was a proposal to change _childDocuments in
SolrDocumentBase to a Map, to incorporate the relationship between the parent and its child
documents.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message