lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "mosh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12361) Change _childDocuments to Map
Date Mon, 21 May 2018 05:09:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482200#comment-16482200
] 

mosh commented on SOLR-12361:
-----------------------------

bq. Oh yeah; the multi-valued question makes this solution path more complicated because it
needs to duplicate similar logic that exists for plain field values. add(key,Object) is ugly.
Ugh. Could you please try the approach of adding SolrInputDocuments as if they were fields
values?
I have started doing this in another branch, this might be the better way to go, but it will
require a lot of adjusting of current unit tests.
Hopefully I'll have a WIP pull request up by tomorrow.

> Change _childDocuments to Map
> -----------------------------
>
>                 Key: SOLR-12361
>                 URL: https://issues.apache.org/jira/browse/SOLR-12361
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: mosh
>            Priority: Major
>         Attachments: SOLR-12361.patch, SOLR-12361.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> During the discussion on SOLR-12298, there was a proposal to change _childDocuments in
SolrDocumentBase to a Map, to incorporate the relationship between the parent and its child
documents.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message