lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8308) migrate KeywordRepeatFilter to conditional tokenstreams
Date Fri, 11 May 2018 16:38:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472229#comment-16472229
] 

Robert Muir commented on LUCENE-8308:
-------------------------------------

The other idea in mind being that we extend LUCENE-8273 to support "else" essentially. Then
this repeater case would be more transparent/obvious, it fires for both the "if" and the "else".

> migrate KeywordRepeatFilter to conditional tokenstreams
> -------------------------------------------------------
>
>                 Key: LUCENE-8308
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8308
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: modules/analysis
>            Reporter: Robert Muir
>            Priority: Major
>
> we should deprecate KeywordAttribute in favor of LUCENE-8273 which gives the analysis
chain a real "if".
> But this isn't straightforward unless we address the KeywordRepeatFilter which sends
the token "both ways" down the branch condition. Maybe it can be handled as a subclass.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message