lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-12337) Remove QueryWrapperFilter
Date Tue, 22 May 2018 03:36:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-12337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483445#comment-16483445
] 

David Smiley commented on SOLR-12337:
-------------------------------------

In this updated patch, I further removed QueryWrapperFilter and its test.  The only remaining
use of the class was in AbstractAnalyticsFieldTest (analytics contrib, tests) which was a
very unnecessary use of Filters to simply know which docs were live (not deleted).
I don't see a need to leave QWF in 7x; Filters _are_ Queries.
I plan to commit tomorrow.

> Remove QueryWrapperFilter
> -------------------------
>
>                 Key: SOLR-12337
>                 URL: https://issues.apache.org/jira/browse/SOLR-12337
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Major
>             Fix For: 7.4
>
>         Attachments: SOLR-12337.patch, SOLR-12337.patch
>
>
> QueryWrapperFilter has not been needed ever since Filter was changed to extend Query
-- LUCENE-1518.  It was retained because there was at least one place in Lucene that had a
Filter/Query distinction, but it was forgotten when Filter moved to Solr.  It contains some
code that creates a temporary IndexSearcher but forgets to null out the cache on it, and so
QueryWrapperFilter can add non-trivial overhead.  We should simply remove it altogether.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message