lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <j...@apache.org>
Subject [jira] [Created] (SOLR-12301) Umbrella issue: paramaterize logging calls in Solr, use consistent naming conventions for the logger
Date Tue, 01 May 2018 18:52:00 GMT
Erick Erickson created SOLR-12301:
-------------------------------------

             Summary: Umbrella issue: paramaterize logging calls in Solr, use consistent naming
conventions for the logger
                 Key: SOLR-12301
                 URL: https://issues.apache.org/jira/browse/SOLR-12301
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
            Reporter: Erick Erickson
            Assignee: Erick Erickson


See the discussion at SOLR-12286 for a lot of background, but the short form is that logging
calls of the form

log.info("somehting" + "something");
and
log.info("soemthing {}", object.toString());

generate useless garbage even when logging at a more restrictive level (say WARN), whereas

log.info("somehting {}", "something");
and
log.infl("soemthing {}", object);

do not. The first form is something of a relic, and there are even some uses of the second.

So, let's tackle subsets of the source code as subordinate JIRAs





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message