lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Benedetti (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-8326) More Like This Params Refactor
Date Wed, 23 May 2018 15:41:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487484#comment-16487484
] 

Alessandro Benedetti edited comment on LUCENE-8326 at 5/23/18 3:40 PM:
-----------------------------------------------------------------------

It is very annoying that the patch automatically generated from the Github Pull Request (
which is green to merge with the master) actually ends up being malformed...

I attach a fixed patch now, just built straight from command line.
 The Pull Request is still valid from a code review perspective.


was (Author: alessandro.benedetti):
It is very annoying that the patch automatically generated from the Github Pull Request (
which is green to merge with the master) actually ends up being malformed...

I attacha fixed patch now, just built straight from command line.
The Pull Request is still valid from a code review perspective.

> More Like This Params Refactor
> ------------------------------
>
>                 Key: LUCENE-8326
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8326
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alessandro Benedetti
>            Priority: Major
>         Attachments: LUCENE-8326.patch, LUCENE-8326.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> More Like This ca be refactored to improve the code readability, test coverage and maintenance.
> Scope of this Jira issue is to start the More Like This refactor from the More Like This
Params.
> This Jira will not improve the current More Like This but just keep the same functionality
with a refactored code.
> Other Jira issues will follow improving the overall code readability, test coverage and
maintenance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message