lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno Roustant (JIRA)" <>
Subject [jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching
Date Tue, 15 May 2018 15:43:00 GMT


Bruno Roustant commented on SOLR-11865:

Great! I agree with all your points [~dsmiley].

Indeed the String IDs in Elevation would be clearer as BytesRefs. And I vote to apply the key
String => indexed form as early as possible, if the code remains small.

> Refactor QueryElevationComponent to prepare query subset matching
> -----------------------------------------------------------------
>                 Key: SOLR-11865
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SearchComponents - other
>    Affects Versions: master (8.0)
>            Reporter: Bruno Roustant
>            Priority: Minor
>              Labels: QueryComponent
>             Fix For: master (8.0)
>         Attachments: 0001-Refactor-QueryElevationComponent-to-introduce-Elevat.patch,
0002-Refactor-QueryElevationComponent-after-review.patch, 0003-Remove-exception-handlers-and-refactor-getBoostDocs.patch,
> The goal is to prepare a second improvement to support query terms subset matching or
query elevation rules.
> Before that, we need to refactor the QueryElevationComponent. We make it extendible.
We introduce the ElevationProvider interface which will be implemented later in a second patch
to support subset matching. The current full-query match policy becomes a default simple MapElevationProvider.
> - Add overridable methods to handle exceptions during the component initialization.
> - Add overridable methods to provide the default values for config properties.
> - No functional change beyond refactoring.
> - Adapt unit test.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message