lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-11865) Refactor QueryElevationComponent to prepare query subset matching
Date Thu, 17 May 2018 21:29:01 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479751#comment-16479751
] 

David Smiley commented on SOLR-11865:
-------------------------------------

Bruno, can you please use a GitHub PR (referencing this issue in the title so that it auto-links)
to push your commits/patches?  It's way easier to do back & forth code review using GitHub.
 I have a new patch but I'd rather apply it to a feature-branch/PR where you (and anyone
else) can see the deltas more easily.

> Refactor QueryElevationComponent to prepare query subset matching
> -----------------------------------------------------------------
>
>                 Key: SOLR-11865
>                 URL: https://issues.apache.org/jira/browse/SOLR-11865
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SearchComponents - other
>    Affects Versions: master (8.0)
>            Reporter: Bruno Roustant
>            Priority: Minor
>              Labels: QueryComponent
>             Fix For: master (8.0)
>
>         Attachments: 0001-Refactor-QueryElevationComponent-to-introduce-Elevat.patch,
0002-Refactor-QueryElevationComponent-after-review.patch, 0003-Remove-exception-handlers-and-refactor-getBoostDocs.patch,
SOLR-11865.patch
>
>
> The goal is to prepare a second improvement to support query terms subset matching or
query elevation rules.
> Before that, we need to refactor the QueryElevationComponent. We make it extendible.
We introduce the ElevationProvider interface which will be implemented later in a second patch
to support subset matching. The current full-query match policy becomes a default simple MapElevationProvider.
> - Add overridable methods to handle exceptions during the component initialization.
> - Add overridable methods to provide the default values for config properties.
> - No functional change beyond refactoring.
> - Adapt unit test.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message