lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shawn Heisey (JIRA)" <>
Subject [jira] [Commented] (SOLR-11453) Create separate logger for slow requests
Date Sun, 06 May 2018 17:15:00 GMT


Shawn Heisey commented on SOLR-11453:

[~varunthacker], I'm going to attach the code patch I was developing, with some ideas you
can use or not as you desire.

In accordance with some best practices mentioned on SOLR-12286, I removed usages of "log.isXxxxEnabled()"
methods.  That is the idea I was most interested in telling you about.

I noticed the SolrCore class has an empty top-level Javadoc. Which makes precommit pass, but
doesn't give anyone any information about the class.  That's a rather glaring omission IMHO.
 Adding it is probably out of scope for this issue.

One of the warnings I noticed in eclipse is that serialVersionUID  was missing from an inner
anonymous class, so I had eclipse add that. Also not important for this issue.

> Create separate logger for slow requests
> ----------------------------------------
>                 Key: SOLR-11453
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: logging
>    Affects Versions: 7.0.1
>            Reporter: Shawn Heisey
>            Assignee: Shawn Heisey
>            Priority: Minor
>         Attachments: SOLR-11453.patch, SOLR-11453.patch, SOLR-11453.patch, SOLR-11453.patch,
> There is some desire on the mailing list to create a separate logfile for slow queries.
 Currently it is not possible to do this cleanly, because the WARN level used by slow query
logging within the SolrCore class is also used for other events that SolrCore can log.  Those
messages would be out of place in a slow query log.  They should typically stay in main solr
> I propose creating a custom logger for slow queries, similar to what has been set up
for request logging.  In the SolrCore class, which is org.apache.solr.core.SolrCore, there
is a special logger at org.apache.solr.core.SolrCore.Request.  This is not a real class, just
a logger which makes it possible to handle those log messages differently than the rest of
Solr's logging.  I propose setting up another custom logger within SolrCore which could be

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message