lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shawn Heisey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-11453) Create separate logger for slow requests
Date Thu, 10 May 2018 00:08:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469732#comment-16469732
] 

Shawn Heisey commented on SOLR-11453:
-------------------------------------

A separate issue for sysprop usage would be a good idea.

Also a separate issue:  Eventually, as part of the overall drive to reduce log verbosity,
I think we should have an option to send things from o.a.s.SolrCore.RequestLog to a separate
logfile.  Not sure that we want that enabled by default, but perhaps we can poll the user
list for opinions about whether it should be enabled by default in 8.0.  There might be a
significant chunk of the userbase that wants it.  The only drawback in my mind to a separate
request log is that it's more difficult to put the requests in context with everything in
solr.log.

For the log4j2.xml config, are you thinking of disabling additivity so that the slow requests
are ONLY logged to the separate file?  I think that's a good idea.


> Create separate logger for slow requests
> ----------------------------------------
>
>                 Key: SOLR-11453
>                 URL: https://issues.apache.org/jira/browse/SOLR-11453
>             Project: Solr
>          Issue Type: Improvement
>          Components: logging
>    Affects Versions: 7.0.1
>            Reporter: Shawn Heisey
>            Assignee: Shawn Heisey
>            Priority: Minor
>         Attachments: SOLR-11453.patch, SOLR-11453.patch, SOLR-11453.patch, SOLR-11453.patch,
slowlog-informational.patch, slowlog-informational.patch, slowlog-informational.patch
>
>
> There is some desire on the mailing list to create a separate logfile for slow queries.
 Currently it is not possible to do this cleanly, because the WARN level used by slow query
logging within the SolrCore class is also used for other events that SolrCore can log.  Those
messages would be out of place in a slow query log.  They should typically stay in main solr
logfile.
> I propose creating a custom logger for slow queries, similar to what has been set up
for request logging.  In the SolrCore class, which is org.apache.solr.core.SolrCore, there
is a special logger at org.apache.solr.core.SolrCore.Request.  This is not a real class, just
a logger which makes it possible to handle those log messages differently than the rest of
Solr's logging.  I propose setting up another custom logger within SolrCore which could be
org.apache.solr.core.SolrCore.SlowRequest.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message