lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <>
Subject [jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log.trace messages
Date Tue, 01 May 2018 18:50:00 GMT


Erick Erickson commented on LUCENE-7788:

[~cpoerschke] As you've probably seen, I've been agitating for a thorough review of our usage
of logging. I think some of us will be making some active progress along these lines, then
be able to fail the precommit.

So I have several questions:

1> WDYT about failing all logging messages that aren't parameterised? Is there any reason
_any_ logging message should not be parameterised?

2> Let's say we fix up one directory (solr/core for example). Can we turn on the precommit
check on a per-directory basis?

3> Since we're going through the review in the first place we can regularize the names
of the loggers to whatever we want. It looks like "log" is the least number of changes so
it wins by default. WDYT about adding a precommit check for that too?

> fail precommit on unparameterised log.trace messages
> ----------------------------------------------------
>                 Key: LUCENE-7788
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: LUCENE-7788.patch, LUCENE-7788.patch
> SOLR-10415 would be removing existing unparameterised log.trace messages use and once
that is in place then this ticket's one-line change would be for 'ant precommit' to reject
any future unparameterised log.trace message use.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message