lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shawn Heisey <apa...@elyograg.org>
Subject Need eyes on LUCENE-7960
Date Tue, 01 May 2018 21:32:43 GMT
Can someone who groks analysis code look at the PR for
https://issues.apache.org/jira/browse/LUCENE-7960 ?  I suspect that the
patch is making changes beyond what's required to implement the issue,
but my understanding of the code is too limited to know.

I already know that it should be adding a constructor, not changing it. 
Secondary question is whether the current three-arg constructor on these
classes should be deprecated or kept.

Thanks,
Shawn


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message